[FFmpeg-devel] [PATCH] Implement common show_banner and show_version functions

Stefano Sabatini stefano.sabatini-lala
Sun Sep 9 23:15:50 CEST 2007

On date Sunday 2007-09-09 19:47:04 +0200, Michael Niedermayer encoded:
> Hi
> On Sun, Sep 09, 2007 at 06:18:55PM +0200, Stefano Sabatini wrote:
> > Hi all,
> > 
> > the idea is to provide more consistency in behaviour and appearance
> > across the ff* utils. For example to show up the banner on stderr at
> > program startup seems like a good idea, and this patch makes trivial
> > to implement such a feature for ffserver and ffplay too in a
> > consistent manner.
> > 
> > A drawback of this patch is that it requires to define for each
> > ff* tool the variables program_name and program_birth_year.
> you can pass these as arguments or?

Yes like in the attached patch.

But I still somehow prefer the previous way, program_name and
program_birth_year are better defined just one time at the beginning
of the file rather than to be passed around as function arguments.

Anyway I'm OK with this solution too, so please take which you prefer
the best (if any).

Stefano Sabatini
Linux user number 337176 (see http://counter.li.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: implement-common-show-version-and-banner-01.patch
Type: text/x-diff
Size: 4768 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070909/3b5beac5/attachment.patch>

More information about the ffmpeg-devel mailing list