[FFmpeg-devel] [PATCH] configure - organize

Måns Rullgård mans
Wed Sep 19 01:35:55 CEST 2007


Ramiro Polla <ramiro at lisha.ufsc.br> writes:

> M?ns Rullg?rd wrote:
>> Ramiro Ribeiro Polla <ramiro at lisha.ufsc.br> writes:
>>   
>>> Hello,
>>>
>>> configure1.diff adds some comments to organize configure. I'd prefer
>>> if they were 80 columns wide though.
>>>     
>>
>> I find such banners exceedingly ugly.
>>   
>
> And I think the lack of banners makes understanding configure 
> unnecessarily hard. I'm pretty sure I'm not alone when I want to add 
> something to configure but have no idea where's the best place to put 
> it. Sure, I've been reading it for more than a year, so I know my way 
> around a little bit more.
>
> They may be ugly, but they're better to organize configure in logical 
> blocks. I find those single-lined # check x explanations not enough. I 
> have to read each check again and again to see what is it that they are 
> doing.
>
> I don't have any preference for the style in division. Do you think you 
> could find a way that you like so it's easier to divide configure?

I like them absent.  If you find single-line comments hard to read,
consider fixing your editor to highlight them better.

I don't mind if you reorganise the checks in a more logical order.
I've been meaning to do that myself.

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-devel mailing list