[FFmpeg-devel] [PATCH] RV30/40 decoder

Michael Niedermayer michaelni
Wed Sep 19 20:43:31 CEST 2007


On Wed, Sep 19, 2007 at 09:06:42PM +0300, Kostya wrote:
> On Wed, Sep 19, 2007 at 07:53:01PM +0200, Michael Niedermayer wrote:
> > Hi
> >
> [...] 
> > > I understand that it is hacky and not good but when proper RM demuxer will be introduced
> > > I will gladly drop this code. And decoding per slice is quite fragile and may
> > > result in consequent frame corruptions due to parsing errors.
> > 
> > maybe its not your job to fix the demuxer, but you worked around the bug
> > in the demuxer by joining split slices in the decoder this is unacceptable
> > and the rv30/40 decoder is rejected as long as this code is in it
> I think it's container design bug. If you see any way how demuxer can join slice end
> by using only container data then I will write a patch (like I did for multiple
> slices in packet case).
> But I could not find the way to determine if it's a loose end or another slice
> without parsing its header.
> Well, I'm awaiting your suggestions on how to resolve this situation and remove that
> workaround.

make the lavf rm demuxer return frames in the format roberto posted (=the
format matroska uses)

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070919/3c45c6b2/attachment.pgp>

More information about the ffmpeg-devel mailing list