[FFmpeg-devel] [PATCH] configure - organize

[Ramiro Ribeiro Polla]

Ramiro Ribeiro Polla wrote:
>  wrote:
>   
>> Ramiro Polla <ramiro at lisha.ufsc.br> writes:
>>
>>   
>>     
>>> M?ns Rullg?rd wrote:
>>>     
>>>       
>>>> Ramiro Ribeiro Polla <ramiro at lisha.ufsc.br> writes:
>>>>   
>>>>       
>>>>         
>>>>> Hello,
>>>>>
>>>>> configure1.diff adds some comments to organize configure. I'd prefer
>>>>> if they were 80 columns wide though.
>>>>>     
>>>>>         
>>>>>           
>>>> I find such banners exceedingly ugly.
>>>>   
>>>>       
>>>>         
>>> And I think the lack of banners makes understanding configure 
>>> unnecessarily hard. I'm pretty sure I'm not alone when I want to add 
>>> something to configure but have no idea where's the best place to put 
>>> it. Sure, I've been reading it for more than a year, so I know my way 
>>> around a little bit more.
>>>
>>> They may be ugly, but they're better to organize configure in logical 
>>> blocks. I find those single-lined # check x explanations not enough. I 
>>> have to read each check again and again to see what is it that they are 
>>> doing.
>>>
>>> I don't have any preference for the style in division. Do you think you 
>>> could find a way that you like so it's easier to divide configure?
>>>     
>>>       
>> I like them absent.  If you find single-line comments hard to read,
>> consider fixing your editor to highlight them better.
>>   
>>     
>
> What I meant was:
>
> ##########
> # Check for grab devices
> ##########
>
> # check for grab device 1
> (...)
> # check for grab device 2
> (...)
> # check for grab device x
> (...)
>
> ##########
> # Check for vhooks
> ##########
>
> # check for dlopen
> (...)
> # check for imlib
> (...)
> # check for freetype
> (...)
>
> ##########
> # Check for instruction set support
> ##########
>
> # check for armv5te
> (...)
> # check for armv6
> (...)
> # check for mmi
> (...)
>
> This way someone that hasn't written the entire configure script might 
> have a chance of finding a logical structure in it.
>   

Did you understand what I meant with my previous e-mail?

Think of it as documenting configure. FFmpeg really lacks documentation. 
Not because its developers are against documentation, but for whatever 
other reasons. If you don't want to do it yourself, that's fine, but I 
proposed to do it, so it's me "wasting" my time doing it, and not you.

Please give us technical reasons as to why you don't want configure to 
have a greater order of organization for logical blocks. Finding such 
banners "exceedingly ugly" is purely personal.

As I've said, I don't mind of what style is used to divide them, as long 
as it's easy to spot where each block starts and ends.

Ramiro Polla