[FFmpeg-devel] [PATCH] configure - organize

Diego Biurrun diego
Mon Sep 24 14:37:50 CEST 2007


On Wed, Sep 19, 2007 at 12:35:55AM +0100, M?ns Rullg?rd wrote:
> Ramiro Polla <ramiro at lisha.ufsc.br> writes:
> 
> > M?ns Rullg?rd wrote:
> >> Ramiro Ribeiro Polla <ramiro at lisha.ufsc.br> writes:
> >>   
> >>> configure1.diff adds some comments to organize configure. I'd prefer
> >>> if they were 80 columns wide though.
> >>
> >> I find such banners exceedingly ugly.
> >
> > And I think the lack of banners makes understanding configure 
> > unnecessarily hard. I'm pretty sure I'm not alone when I want to add 
> > something to configure but have no idea where's the best place to put 
> > it. Sure, I've been reading it for more than a year, so I know my way 
> > around a little bit more.
> >
> > They may be ugly, but they're better to organize configure in logical 
> > blocks. I find those single-lined # check x explanations not enough. I 
> > have to read each check again and again to see what is it that they are 
> > doing.
> >
> > I don't have any preference for the style in division. Do you think you 
> > could find a way that you like so it's easier to divide configure?
> 
> I like them absent.  If you find single-line comments hard to read,
> consider fixing your editor to highlight them better.

Are single line "section headers" (or whatever you wish to call them)
OK?

Diego




More information about the ffmpeg-devel mailing list