[FFmpeg-devel] [PATCH] Add the function libavcodec/utils.c:avcodec_type_string

Stefano Sabatini stefano.sabatini-lala
Mon Apr 7 12:48:16 CEST 2008


On date Wednesday 2007-11-21 09:58:35 +0100, Stefano Sabatini encoded:
> On date Monday 2007-11-12 09:53:39 +0100, Stefano Sabatini encoded:
> > On date Friday 2007-11-09 15:26:22 +0100, Stefano Sabatini encoded:
> > > On date Friday 2007-11-09 11:34:25 +0100, Stefano Sabatini encoded:
> > > > On date Friday 2007-11-09 09:00:05 +0000, M?ns Rullg?rd encoded:
> > > [...]
> > > > > Why don't you declare the argument as type CodecType?  That should
> > > > > make it abundantly clear what is expected.
> > > > > 
> > > > > Also, why do you use snprintf() here, when av_strlcpy() would do just
> > > > > as well, or even simply returning the string constants.
> > > > [...]
> > > > 
> > > > Yes, it looks like a simpler solution, which I prefer over the
> > > > previous ones.
[...]

Hi, a patch which come back from a distant past, readjusted against the
latest SVN.

Also I added support to the CODEC_TYPE_ATTACHMENT added in r11635.

Best regards.
-- 
Stefano Sabatini
Linux user number 337176 (see http://counter.li.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add-avcodec-type-string-function-07.patch
Type: text/x-diff
Size: 1737 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080407/96c9af77/attachment.patch>



More information about the ffmpeg-devel mailing list