[FFmpeg-devel] [PATCH] BFI demuxer

[Michael Niedermayer]

On Sat, Apr 12, 2008 at 12:07:40PM +0530, Sisir Koppaka wrote:
> Thanks!
> 
> On Sat, Apr 12, 2008 at 2:51 AM, Michael Niedermayer <michaelni at gmx.at>
> wrote:
> 
> > On Sat, Apr 12, 2008 at 12:30:38AM +0530, Sisir Koppaka wrote:
> > >
> > [...]
> > > +    /* Setting total number of frames. */
> > > +    url_fseek(pb, 8, SEEK_CUR);
> >
> > url_fskip()
> >
> I looked up the definition of url_fskip and it's only a one line function
> which again calls url_fseek(pb, x, SEEK_CUR) and hence, to prevent the
> unnecessary function call, I put that directly here. Anyway, since you've
> pointed out this twice, I've changed it to fskip now, but is there any
> specific reason why fskip is preferable to fseek in this case considering
> the extra function call overhead?

No its just a minor preferance of mine. Speed really doesnt matter here its
just executed once per file.


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored awnser#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080412/358bea02/attachment.pgp>