[FFmpeg-devel] [PATCH] BFI demuxer

[Diego Biurrun]

On Sat, Apr 12, 2008 at 12:27:08PM +0530, Sisir Koppaka wrote:
> --- bfi.c	(revision 0)
> +++ bfi.c	(revision 24)
> @@ -0,0 +1,210 @@
> +/*
> + * Brute Force & Ignorance(BFI) Demuxer

Brute Force & Ignorance (BFI) demuxer

> + * Copyright (c) 2008 Sisir Koppaka.

useless period

> +    /*Loading palette to extradata */

nit: /* Loading palette into extradata */

All of these comments should IMO not use gerunds.  Just use

  /* Load palette into extradata. */

> +    url_fseek(pb, 8, SEEK_CUR);
> +    vstream->codec->extradata = av_malloc(768);
> +    vstream->codec->extradata_size = 768;
> +    get_buffer(pb, vstream->codec->extradata,
> +               vstream->codec->extradata_size);
> +
> +    sample_rate      = get_le32(pb);

peculiar spacing..

> +    /*If all previous chunks were completely read, we try to find a new one... */

long line

> +AVInputFormat bfi_demuxer = {
> +    "bfi",
> +    "Brute Force & Ignorance",
> +    sizeof(BFIContext),
> +    bfi_probe,
> +    bfi_read_header,
> +    bfi_read_packet,
> +    bfi_read_close,
> +/*Some more present in libavformat/avformat.h...check out later. */

?

Build system part of the patch OK, but you need to update the
documentation and the Changelog with the new demuxer.

Diego