[FFmpeg-devel] [PATCH] BFI demuxer

[Michael Niedermayer]

On Sun, Apr 13, 2008 at 04:47:56PM +0530, Sisir Koppaka wrote:
> Updated patch attached. Fixed the probe function.
> 
> On Sun, Apr 13, 2008 at 3:02 PM, Diego Biurrun <diego at biurrun.de> wrote:
> 
> > On Sun, Apr 13, 2008 at 01:25:58PM +0530, Sisir Koppaka wrote:
> > > On Sun, Apr 13, 2008 at 1:19 PM, Diego Biurrun <diego at biurrun.de> wrote:
> > >
> > > > On Sun, Apr 13, 2008 at 09:00:50AM +0530, Sisir Koppaka wrote:
> > > > > Updated patch attached. Added CODEC_ID_BFI to libavcodec/avcodec.h
> > > > >
> > > > > --- libavcodec/avcodec.h      (revision 12790)
> > > > > +++ libavcodec/avcodec.h      (working copy)
> > > > > @@ -183,6 +183,7 @@
> > > > >      CODEC_ID_8SVX_FIB,
> > > > >      CODEC_ID_ESCAPE124,
> > > > >      CODEC_ID_DIRAC,
> > > > > +    CODEC_ID_BFI,
> > > >
> > > > That's the list of video codecs, not audio codecs.
> > >
> > > +    vstream->codec->codec_type = CODEC_TYPE_VIDEO;
> > > > +    vstream->codec->codec_id   = CODEC_ID_BFI;
> > > The format uses the PCM audio decoder and the  soon-to-be-added BFI
> > video
> > > decoder.  So, shouldn't the CODEC_ID_BFI be in the list of video codecs
> > as
> > > it is now?
> >
> > I thought CODEC_ID_BFI was an audio codec.  If it is a video codec, then
> > it is in the correct place.
> >
> > Anyway, your patch still has severe problems.  ffplay suddenly detects
> > almost everything as BFI.  Some random examples:
> >
> > http://samples.mplayerhq.hu/ogg/mpeg-in-ogm.ogm
> > http://samples.mplayerhq.hu/game-formats/wc3-mve/wc3-arrest.mve
> > http://samples.mplayerhq.hu/game-formats/vp6/NFSU2/FMVOpening.vp6
> > http://samples.mplayerhq.hu/game-formats/delphine_cin/LOGO.CIN
> >
> I checked it up and found that AVI files were playing fine and only those
> formats that came alphabetically after BFI were not playing...there were two
> bugs in the probe function(endianess + (archaic) exactly opposite if
> condition check) which were leading the BFI probe to claim everything.  I
> fixed them and checked that the videos listed above were playing. BFI files
> are also playing now, so the probe function is correct now. Sorry for this
> trouble.

patch still look ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080413/ce42c645/attachment.pgp>