[FFmpeg-devel] [PATCH] GSM-MS decoder and encoder

[Michel Bardiaux]

Baptiste Coudurier wrote:
>> [...]
>>
>> +    if (avctx->bit_rate != 13000 /* Official */ &&
>> +        avctx->bit_rate != 13200 /* Very common */ &&
>> +        avctx->bit_rate != 0 /* Unknown, happens in some MOV */ ) {
> 
> Something like: "mov does not set bitrate when decoding" might be clearer.

OK.

> 
>> [...]
>>
>>  static int libgsm_decode_frame(AVCodecContext *avctx,
>>                                 void *data, int *data_size,
>>                                 uint8_t *buf, int buf_size) {
>> -
>> -    if(buf_size < avctx->block_align) return 0;
>> -
>> +    *data_size = 0; /* In case of error */
>> +    if(buf_size < avctx->block_align) return -1;
>>      switch(avctx->codec_id) {
>>      case CODEC_ID_GSM:
>>          if(gsm_decode(avctx->priv_data,buf,data)) return -1;
>>
> 
> This must be in a separate commit.
> 

OK. New (first) patch.

-- 
Michel Bardiaux
R&D Director
T +32 [0] 2 790 29 41
F +32 [0] 2 790 29 02
E mailto:mbardiaux at mediaxim.be

Mediaxim NV/SA
Vorstlaan 191 Boulevard du Souverain
Brussel 1160 Bruxelles
http://www.mediaxim.com/
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: gsm.pat
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080425/3b9f9dc7/attachment.txt>