[FFmpeg-devel] [PATCH] Common ACELP routines (3/3) - LPC decoding routines

[Michael Niedermayer]

On Fri, Apr 25, 2008 at 11:57:24PM +0700, Vladimir Voroshilov wrote:
> On 4/25/08, Vladimir Voroshilov <voroshil at gmail.com> wrote:
[...]
> > > also please change the Q12/15 notation to some normal fixed point one with
> > > min/one/max
> > 
> > Like this?:
> > 
> > /**
> >  * \param param1 bla bla bla
> > ...
> >  * \return some value
> >  *
> >  *  allowed values for param1:
> >  *   min: -0x10000
> >  *   max:  0x10000
> >  *   one   0x01000
> >  */
> > 
> > Or something different?
> > Give me sample please.
> 
> Waiting for answer.
> Currently kept Q[n] notation as is.

[...]

> +void ff_acelp_reorder_lsf(int16_t* lsfq, int lsfq_min_distance, int lsfq_min, int lsfq_max)
> +{
> +    int i, j;
> +
> +    /* sort lsfq in ascending order. float bubble agorithm, O(n)*/

Its O(n) if already sorted otherwise its O(n^2)

anyway the patch looks ok except this and the Q* notation

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080426/8757a384/attachment.pgp>