[FFmpeg-devel] [PATCH] Common ACELP routines (2/3) - filters

[Diego Biurrun]

On Sun, Apr 27, 2008 at 05:44:46PM +0700, Vladimir Voroshilov wrote:
> On Sun, Apr 27, 2008 at 4:56 PM, Diego Biurrun <diego at biurrun.de> wrote:
> > On Sun, Apr 27, 2008 at 01:05:07AM +0700, Vladimir Voroshilov wrote:
> [...]
> 
> >  > +    if(pitch_delay_frac < 0)
> >  > +    {
> >
> >  I think Michael prefers braces on the same line.
> 
> All issues except this are fixed.

Ummm, no :)

> --- /dev/null
> +++ b/libavcodec/acelp_filters.c
> @@ -0,0 +1,261 @@
> +
> +    /* The lookup table contain values corresponding

containS

> +       The filtering process uses a negative pitch lag offset, but
> +       a negative offset should not be used in then table. To avoid
> +       a negative offset in the table dimension corresponding to
> +       fractional delay the following conversion applies:

delay,

> +        // Clippin is required to pass G.729 OVERFLOW test

ClippinG

> --- /dev/null
> +++ b/libavcodec/acelp_filters.h
> @@ -0,0 +1,125 @@
> +
> + * The routine assumes the following order of fractions (X - integer delay):

fraction order

> + * The routine can be used for 1/3 precision too, by
> + * passing 2*pitch_delay_frac as third parameter

The routine can be used for 1/3 precision by
passing 2*pitch_delay_frac as third parameter.

> +/**
> + * \brief Calculates coefficients of weighted A(z/weight) filter
> + * \param out [out] resulted weighted A(z/weight)
> + *                  filter (-0x8000 <= (3.12) < 0x8000)

resulting

> + * \remark It is safe to pass the same array in in and out parameters

Add a period, could be done in other places as well.

> +#endif // FFMPEG_ACELP_FILTERS_H

I don't like C++ comments :)

Diego