[FFmpeg-devel] Visibility implementation

Luca Barbato lu_zero
Fri Aug 1 12:46:27 CEST 2008


Uoti Urpala wrote:
> On Wed, 2008-07-30 at 10:21 +0200, Diego Biurrun wrote:
>> On Wed, Jul 30, 2008 at 05:45:36AM +0300, Uoti Urpala wrote:
>>> --- a/libavcodec/i386/dsputil_mmx.c
>>> +++ b/libavcodec/i386/dsputil_mmx.c
>>> @@ -788,7 +788,7 @@ static void draw_edges_mmx(uint8_t *buf, int wrap, int width, int height, int w)
>>>  
>>>  #define PAETH(cpu, abs3)\
>>> -void add_png_paeth_prediction_##cpu(uint8_t *dst, uint8_t *src, uint8_t *top, int w, int bpp)\
>>> +static void add_png_paeth_prediction_##cpu(uint8_t *dst, uint8_t *src, uint8_t *top, int w, int bpp)\
>> Unrelated?
> 
> Not really - I changed some globally visible symbols to more limited
> visibility, and because that was only used in the same file I changed it
> to static instead of hidden.
> 

Maybe you could split this hunk so it will be committed first.

lu

-- 

Luca Barbato
Gentoo Council Member
Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero





More information about the ffmpeg-devel mailing list