[FFmpeg-devel] [PATCH] cmdutils.c warning fix

[Michael Niedermayer]

On Sun, Aug 03, 2008 at 01:47:11PM +0200, Diego Biurrun wrote:
> On Sat, Aug 02, 2008 at 07:23:19PM +0200, Michael Niedermayer wrote:
> > On Sat, Aug 02, 2008 at 01:27:07PM +0200, Diego Biurrun wrote:
> > > Here is a small one to get rid of
> > > 
> > > cmdutils.c:226: warning: 'avcodec_build' is deprecated (declared at ./libavcodec/avcodec.h:2534)
> > 
> > the patch is incorrect, and ive alraedy rejected it when (IIRC) stefano 
> > proposed it.
> > avcodec_build() is the version of the linked library, LIBAVCODEC_BUILD is
> > the version of the headers.
> 
> Why is this wrong for libavcodec and correct for all other libs in the
> show_version function?  

Who said it is correct for the others?


> And why is it correct for libavcodec in the
> show_banner function 10 lines above?

Who said it is correct there?


> 
> Anyway, here is a patch using avcodec_version().

ok


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I wish the Xiph folks would stop pretending they've got something they
do not.  Somehow I fear this will remain a wish. -- M?ns Rullg?rd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080803/c1d05581/attachment.pgp>