[FFmpeg-devel] [PATCH] PCM regression tests

[Michael Niedermayer]

On Sun, Aug 03, 2008 at 01:44:46PM +1000, pross at xvid.org wrote:
> Hi,
> 
> Test case for all PCM codecs. Some muxer modifications were required to
> complete the encoder-decoder loop for PCM Zork and S24DAUD.
> 
> add-pcm_zork-to-riff.diff
>   Support muxing of Zork PCM audio into .AVI format.
>   (alternatively, we could drop Zork PCM audio encoding. Is anyone
>    seriously using this?).

not ok, see below


> 
> daud-muxer.diff
>   Add Digital Cinema muxer.

ok


[...]
> @@ -254,6 +255,10 @@
>      } else {
>          bps = 16;
>      }
> +    if (enc->codec_id == CODEC_ID_PCM_ZORK) {
> +        enc->codec_id = CODEC_ID_ADPCM_IMA_WAV;
> +        bps = 8;
> +    }

Iam against this, CODEC_ID_PCM_ZORK is not CODEC_ID_ADPCM_IMA_WAV

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080803/dd4fb17b/attachment.pgp>