[FFmpeg-devel] Implement missing av*_version() functions

[Stefano Sabatini]

On date Sunday 2008-08-03 19:02:40 +0200, Diego Biurrun encoded:
> On Sun, Aug 03, 2008 at 06:56:18PM +0200, Stefano Sabatini wrote:
> > On date Sunday 2008-08-03 17:00:47 +0200, Michael Niedermayer encoded:
> > > On Sun, Aug 03, 2008 at 04:49:05PM +0200, Diego Biurrun wrote:
> > [...]
> > > > What is the problem with mixing the version of the headers and of the
> > > > linked library anyway?  Do I understand correctly that it is for the
> > > > case where ffmpeg/ffplay/ffserver is dynamically linked and the version
> > > > of the linked libs differs from the version of the headers used to
> > > > compile the binary?
> > > 
> > > yes, its kinda usefull for bugreports where the user has several libs and
> > > by mistake linked to the wrong one.
> > > 
> > > > And thus ideally there should be a _version() function for every single
> > > > library?
> > > 
> > > yes
> > 
> > partly based on some patches by Andreas ?man.
> 
> I was about to implement this, you beat me to it, nice :)

:)

> > --- libavutil/Makefile	(revision 14521)
> > +++ libavutil/Makefile	(working copy)
> > @@ -21,6 +21,7 @@
> >         sha1.o \
> >         string.o \
> >         tree.o \
> > +       utils.o
> 
> Add a backslash, this makes adding new entries easier.

Fixed.

> > --- libavdevice/Makefile	(revision 14521)
> > +++ libavdevice/Makefile	(working copy)
> > @@ -5,7 +5,8 @@
> >  
> > -OBJS    = alldevices.o
> > +OBJS    = alldevices.o \
> > +          utils.o
> 
> ditto

Fixed.

> > --- cmdutils.c	(revision 14521)
> > +++ cmdutils.c	(working copy)
> > @@ -223,7 +223,7 @@
> >             "libavcodec  %d\n"
> >             "libavformat %d\n"
> >             "libavdevice %d\n",
> > -           LIBAVUTIL_BUILD, avcodec_version(), LIBAVFORMAT_BUILD, LIBAVDEVICE_BUILD);
> > +           avutil_version(), avcodec_version(), avformat_version(), avdevice_version());
> What about show_banner()?

I think that we should change somehow the behaviour here, maybe we
could avoid to print the various compile-time libav* versions in
show_banner(), which may be deduced anyway from the SVN revision number,
but print both compile-time and link-time/run-time versions in
show_version().

Also I'd like to use human-readable version forms in show_version(),
anyway this is another thread...

While I was at it I also added an avfilter_version() patch.

Regards.
-- 
FFmpeg = Frenzy and Freak Magic Proud Evanescent Gospel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: doxy-lavc-version-00.patch
Type: text/x-diff
Size: 629 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080803/46095e93/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: implement-lavf-version-00.patch
Type: text/x-diff
Size: 1228 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080803/46095e93/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: implement-lavfi-version-00.patch
Type: text/x-diff
Size: 2329 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080803/46095e93/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: implement-lavu-version-01.patch
Type: text/x-diff
Size: 2229 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080803/46095e93/attachment-0003.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: implement-lavdev-version-01.patch
Type: text/x-diff
Size: 2434 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080803/46095e93/attachment-0004.patch>