[FFmpeg-devel] [PATCH] fix 422 sse computation

Michael Niedermayer michaelni
Tue Aug 5 03:31:46 CEST 2008


On Mon, Aug 04, 2008 at 05:50:09PM -0700, Baptiste Coudurier wrote:
> Hi,
> 
> $subject, I believe the patch is correct.
> 
> -- 
> Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
> Smartjog USA Inc.                                http://www.smartjog.com
> Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA

> Index: libavcodec/mpegvideo_enc.c
> ===================================================================
> --- libavcodec/mpegvideo_enc.c	(revision 14539)
> +++ libavcodec/mpegvideo_enc.c	(working copy)
> @@ -1901,6 +1901,7 @@
>  static int sse_mb(MpegEncContext *s){
>      int w= 16;
>      int h= 16;
> +    int mb_h= 16>>s->chroma_y_shift;

i think chr_h is a better name


[...]
> @@ -2012,6 +2013,7 @@
>  static int encode_thread(AVCodecContext *c, void *arg){
>      MpegEncContext *s= arg;
>      int mb_x, mb_y, pdif = 0;
> +    int mb_h= 16>>s->chroma_y_shift;

same

and iam  ok with the patch provided that it has been tested and works

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080805/9fc9f4fc/attachment.pgp>



More information about the ffmpeg-devel mailing list