[FFmpeg-devel] Patch for "non monotone timestamp" error

[Michael Niedermayer]

On Wed, Aug 06, 2008 at 09:49:28AM +0200, Diep Ho wrote:
> > -----Original Message-----
> > From: ffmpeg-devel-bounces at mplayerhq.hu [mailto:ffmpeg-devel-
> > bounces at mplayerhq.hu] On Behalf Of Michael Niedermayer
> > Sent: mardi 5 ao?t 2008 22:39
> > To: FFmpeg development discussions and patches
> > Subject: Re: [FFmpeg-devel] Patch for "non monotone timestamp" error
> > 
> > On Tue, Aug 05, 2008 at 05:45:59PM +0200, Diep Ho wrote:
> > > > -----Original Message-----
> > > > From: ffmpeg-devel-bounces at mplayerhq.hu [mailto:ffmpeg-devel-
> > > > bounces at mplayerhq.hu] On Behalf Of Michael Niedermayer
> > > > Sent: lundi 4 ao?t 2008 19:20
> > > > To: FFmpeg development discussions and patches
> > > > Subject: Re: [FFmpeg-devel] Patch for "non monotone timestamp"
> > error
> > > >
> > > > >
> > > > > Do you want to say that ffmpeg will not support mpeg1 files
> > > > > without
> > > > b-frames anymore?
> > > >
> > > > no, low delay != no b frames
> > >
> > > I totally agree, but in the code I found this logic in some places.
> > Some lines are with a FIXME notice.
> > >
> > > >
> > > >
> > > > > Our files are just mpeg1 files without any b-frames. I don't care
> > > > > if
> > > > they are low_delay or not.
> > > >
> > > > I have never seen any of your files, nor do i know what problem you
> > > > have I just saw a broken patch or 2 from you.
> > >
> > > I have uploaded one example in the directory MPlayer/incoming/dho
> > thru FTP. There you find also a README explaining what is all about.
> > 
> > Ive fixed the encoder so it will fail with an error message if someone
> > tries to encode low delay mpeg1
> 
> This does not solve the problem given that someone can always set -bf 0 with ffmpeg command or set max_b_frames = 0 in his code when encoding a mpeg1 file. 

ive already told you that b frames and low delay are 2 seperate things


> Furthermore, ffmpeg should support files that have been being created with this setting.

because you created such files ...
no, that is no reason to support them.
If such files are widespreadly used it makes sense to support them no matter
what the specs say but a file created by a single person who specified a
combination of options that is invalid no.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080806/7d5918d0/attachment.pgp>