[FFmpeg-devel] [PATCH] Better names for tests/regression.sh?

Stefano Sabatini stefano.sabatini-lala
Sun Aug 10 20:29:52 CEST 2008


Hi all,

I think this patch should make easier to understand regression.sh.

While maybe the chosen names may be improved, I think it is *always* a
good idea to prefer symbolic and meaningful names over numeric (a la
$1) names.

BTW, off-topic but still relevant, what do you tink about to make more
modular each test?

The problem with the current solution is that if you want for example
check the result of just a single test, for example
regtest-mpeg2thread, you have to do:
make regtest-mpeg2thread

then read the files:
mpeg2thread.vsynth.regression
mpeg2thread.rotozoom.regression

and compare them with the corresponding section of:
ffmpeg.regression.ref
rotozoom.regression.ref

Alternatively you have to run make codectest, but in this case you're
going to wait for the result of *all* the tests.

Ideally every test could have a distinct reference file, for example
in this case:
mpeg2thread.vsynth.regression.ref
mpeg2thread.rotozoom.regression.ref

and;
make regfile-TEST

could automatically show the result of the file comparison (which
actually happens only with the global suite of tests, codectest,
libavtest and seektest).

Best regards.
-- 
FFmpeg = Fantastic and Frenzy Mind-dumbing Problematic Elastic Game
-------------- next part --------------
A non-text attachment was scrubbed...
Name: better-names-for-regression-00.patch
Type: text/x-diff
Size: 4756 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080810/f0cb9e4d/attachment.patch>



More information about the ffmpeg-devel mailing list