[FFmpeg-devel] [PATCH] make pcm_dvd use the full bit depth

[François Revol]

> Lars T?uber wrote:
> 
> > this fixes my last patch
> > the sound should be alright again
> > can't test again tonight but will do tomorrow
> > 
> > [...]
> > 
> > @@ -489,7 +505,7 @@
> >  
> >  /* Note: Do not forget to add new entries to the Makefile as well. 
> > */
> >  PCM_CODEC  (CODEC_ID_PCM_ALAW,  SAMPLE_FMT_S16, pcm_alaw, "A-law 
> > PCM");
> > -PCM_CODEC  (CODEC_ID_PCM_DVD,   SAMPLE_FMT_S16, pcm_dvd, "signed 
> > 16|20|24-bit big-endian PCM");
> > +PCM_CODEC  (CODEC_ID_PCM_DVD,   SAMPLE_FMT_S32, pcm_dvd, "signed 
> > 20|24-bit big-endian PCM");
> 
> I guess it should be SAMPLE_FMT_S24.
> But I'm not sure if a final decision was made about internal storage
> format of SAMPLE_FMT_S24. I think Michael wanted it to be the same as
> SAMPLE_FMT_S32, so this would require no more change to your code.

As reference, here are the 24 bit format used by OSSv4:
http://manuals.opensound.com/developer/AFMT_S24_LE.html
http://manuals.opensound.com/developer/AFMT_S24_BE.html
http://manuals.opensound.com/developer/AFMT_S24_PACKED.html ... :)

Seems they use padded 32 bit actually.

:)

Fran?ois.