[FFmpeg-devel] [PATCH] Initialize crc data in mlp_parser.c in its own function.

Ramiro Polla ramiro.polla
Wed Aug 13 04:17:00 CEST 2008


Hello,

Attached patch initializes crc data from mlp_parser.c in its own function.

This removes the if (!crc_init) out of every call to mlp_checksum16().
It will also help in sharing the crc data between encoder and decoder.

One thing though. The parser uses crc_2d, the decoder uses crc_1d and
crc_63, and the encoder uses all three. Is it ok to assume that the
decoder will need the parser, and that the parser will be used for the
decoder, and hence make both (parser and decoder) call an
ff_mlp_init_crc() function that initializes all three crc structs?
That way it's easier to share the same init function with the encoder.

Ramiro Polla
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mlp_parse_init.diff
Type: text/x-diff
Size: 888 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080812/c5d8b97d/attachment.diff>



More information about the ffmpeg-devel mailing list