[FFmpeg-devel] [PATCH] Split common code for MLP to mlp.[ch].

Ramiro Polla ramiro.polla
Wed Aug 13 05:38:07 CEST 2008


Hello,

Attached patches remove common code from the MLP encoder in the SoC
repo and the decoder (and the parser) and puts it in common files.

To commit, the split to mlp.[ch] would be made with svn cp from
mlpdec.c. I attached them as the resulting file to easy reviewing (or
is it better to have the diffs to mlpdec.c?).

The encoder doesn't support as much stuff as the decoder yet, so there
are more things that could probably be shared in the future. These
are:
- The noise table, which can probaly be shared now since I'm almost
certain it will be used;
- The noise generation functions, which depend heavily on
MLPDecodeContext, but should instead depend on common contexts and
more generic parameters;
- The Substr header, which has not yet been fully split like in the
encoder. When properly split, more stuff could be shared, and
MLPDecodeContext and MLPEncodeContext would use most of the same
structs.

Ramiro Polla
-------------- next part --------------
A non-text attachment was scrubbed...
Name: split_mlpdec.diff
Type: text/x-diff
Size: 11594 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080813/29b2dd1a/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mlp.c
Type: text/x-csrc
Size: 3456 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080813/29b2dd1a/attachment.c>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mlp.h
Type: text/x-chdr
Size: 4260 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080813/29b2dd1a/attachment.h>



More information about the ffmpeg-devel mailing list