[FFmpeg-devel] [PATCH] Split common code for MLP to mlp.[ch].
Wed Aug 13 17:01:45 CEST 2008
On Wed, Aug 13, 2008 at 11:23:42AM -0300, Ramiro Polla wrote:
> On Wed, Aug 13, 2008 at 11:14 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Wed, Aug 13, 2008 at 10:14:51AM -0300, Ramiro Polla wrote:
> >> On Wed, Aug 13, 2008 at 10:13 AM, Ramiro Polla <ramiro.polla at gmail.com> wrote:
> >> > Hello,
> >> >
> >> > I replied to this e-mail with two sets of big patches and it was too
> >> > big for the ML. I'm sending them again separately.
> >> >
> >> > On Wed, Aug 13, 2008 at 9:38 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> >> SSOn Wed, Aug 13, 2008 at 12:38:07AM -0300, Ramiro Polla wrote:
> >> >>> Hello,
> >> >>>
> >> >>> Attached patches remove common code from the MLP encoder in the SoC
> >> >>> repo and the decoder (and the parser) and puts it in common files.
> >> >>>
> >> >>> To commit, the split to mlp.[ch] would be made with svn cp from
> >> >>> mlpdec.c. I attached them as the resulting file to easy reviewing (or
> >> >>> is it better to have the diffs to mlpdec.c?).
> >> >>
> >> >> you could just attach both they are both usefull for reviewing
> >> >
> >> > I'm attaching them as diffs again. One for each file, but to be
> >> > committed all at once. What changed is that I removed the duplicate
> >> > comment for both checksum functions in mlp.h. Also I copied with the
> >> > */ in the same line, since that's how it is in mlpdec.
> >> >
> >> > I'll post a followup to this reply with the second set of patches.
> >> And here they are. The difference between the previous ones is that
> >> they have mlp_parse_init call a function in mlp_parser.c which in turn
> >> calls the common function in mlp.c. This way we can avoid #include'ing
> >> avcodec.h in mlp.h. It's attached as mlp_parser_2.c.diff,
> >> mlp_2.c.diff, and mlp_2.h.diff. mlpdec.c.diff is the same as the
> >> previous e-mail.
> > too large iam not going to review this, the patch should be against the
> > previous approved version.
> Sorry, I didn't make myself very clear. It's either this email's
> patches, or the previous email's patches. There would be no point in
> applying previous patch and then moving mlp_parse_init back into
> mlp_parser (it's the only difference, just look at
> mlp_parser_2.c.diff, it's smaller).
ok, i dont fully understand why you posted these huge patches if they are
anyway apply what i approved.
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The misfortune of the wise is better than the prosperity of the fool.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel