[FFmpeg-devel] [PATCH] MLP Encoder

[Aurelien Jacobs]

Ramiro Polla wrote:

> On Thu, Aug 14, 2008 at 6:42 PM, Aurelien Jacobs <aurel at gnuage.org> wrote:
> > Michael Niedermayer wrote:
> >
> >> On Thu, Aug 14, 2008 at 02:08:45AM -0300, Ramiro Polla wrote:
> >>
> >> [...]
> >> > Index: libavformat/raw.c
> >> > ===================================================================
> >> > --- libavformat/raw.c       (revision 14733)
> >> > +++ libavformat/raw.c       (working copy)
> >> > @@ -596,6 +596,21 @@
> >> >  };
> >> >  #endif
> >> >
> >> > +#ifdef CONFIG_MUXERS
> >> > +AVOutputFormat mlp_muxer = {
> >> > +    "mlp",
> >> > +    NULL_IF_CONFIG_SMALL("raw MLP"),
> >> > +    NULL,
> >> > +    "mlp",
> >> > +    0,
> >> > +    CODEC_ID_MLP,
> >> > +    CODEC_ID_NONE,
> >> > +    NULL,
> >> > +    raw_write_packet,
> >> > +    .flags= AVFMT_NOTIMESTAMPS,
> >> > +};
> >> > +#endif //CONFIG_MUXERS
> >> > +
> >> >  AVInputFormat flac_demuxer = {
> >> >      "flac",
> >> >      NULL_IF_CONFIG_SMALL("raw FLAC"),
> >>
> >> ok
> >
> > The #ifdef should be against CONFIG_MLP_MUXER instead of CONFIG_MUXERS.
> 
> Is this how it is supposed to be #ifdef'd now?

Yes. And since a long time.
mlp_muxer is only referenced from allformats.c and only under #ifdef
CONFIG_MLP_MUXER.
But there are still lots of places using CONFIG_MUXERS (and similar)
which should be changed.

> I and Diego have asked ourselves why is CONFIG_MUXERS even
> used in these cases, and not the specific muxers (and demuxers
> accordingly).

Because those CONFIG_MUXERS were added before the specific muxers
define were introduced.

Aurel