[FFmpeg-devel] [PATCH] change the order of params for av_init_random()

Michael Niedermayer michaelni
Sun Aug 17 23:27:02 CEST 2008


On Sun, Aug 17, 2008 at 10:06:01PM +0100, M?ns Rullg?rd wrote:
> Justin Ruggles <justinruggles at bellsouth.net> writes:
[...]
> > Index: libavutil/random.c
> > ===================================================================
> > --- libavutil/random.c	(revision 14819)
> > +++ libavutil/random.c	(working copy)
> > @@ -36,7 +36,7 @@
> >  #define LOWER_MASK 0x7fffffff /* least significant r bits */
> >  
> >  /** initializes mt[AV_RANDOM_N] with a seed */
> > -void av_init_random(unsigned int seed, AVRandomState *state)
> > +void av_init_random(AVRandomState *state, unsigned int seed)
> 
> This requires a major version bump, since it breaks ABI.

i dont think anyone is using it, besides its not hard to add a
av_init_random2() and make av_init_random() call it if someone
wants it.
If not iam fine with the original patch.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080817/6615adc8/attachment.pgp>



More information about the ffmpeg-devel mailing list