[FFmpeg-devel] [VOTE] License header consistency

Michael Niedermayer michaelni
Mon Aug 18 16:23:22 CEST 2008


On Mon, Aug 18, 2008 at 03:02:37PM +0100, M?ns Rullg?rd wrote:
> 
> Ivan Kalvachev wrote:
> > On 8/18/08, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> On Mon, Aug 18, 2008 at 09:05:57AM +0300, Tomi Ollila wrote:
> >>> On Mon 18 Aug 2008 08:54, Tomi Ollila <tomi.ollila at guru.guru-group.fi>
> >>> writes:
> >>>
> >>> >
> >>> > What kind of pre-commit hook ?
> >>> >
> >>> > Like this?
> >>> >
> >>> > --8<----8<----8<----8<----8<----8<----8<----8<----8<----8<--
> >>> heavily buggy version deleted
> >>> > --8<----8<----8<----8<----8<----8<----8<----8<----8<----8<--
> >>>
> >>> #!/bin/sh
> >>>
> >>> case `head -n <l1> <f> | tr -d \\015 | sha1sum` in <sum-of-gpl-2.1>*) exit
> >>> 0 ;; esac
> >>> case `head -n <l2> <f> | tr -d \\015 | sha1sum` in <sum-of-lgpl-2.0>*)
> >>> exit 0 ;; esac
> >>>
> >>> echo "File '<f>' license header mismatch. >&2
> >>> exit 1
> >>
> >> The license headers look like:
> >> /*
> >>  * copyright (c) 2001 Fabrice Bellard
> >>  *
> >>  * This file is part of FFmpeg.
> >> ...
> >> the first line will likely lead to sha1 mismatches
> >
> > This check would also exclude the possibility of using more permissive
> > licenses like BSD, MIT, public code - e.g. vc1dsp_mmc.c
> 
> Good point.  We could have a list of allowed licenses, of course.

I think a better, and easier to maintain approch would be to grep for
the problematic parts in head -n 123 file
that is "this library" "<non existent version>" "<old address>"

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080818/e122df8a/attachment.pgp>



More information about the ffmpeg-devel mailing list