[FFmpeg-devel] [PATCH] deprecate SAMPLE_FMT_S24

Peter Ross pross
Tue Aug 19 14:29:32 CEST 2008


On Sun, Aug 17, 2008 at 05:10:39PM +0200, Michael Niedermayer wrote:
> On Sun, Aug 17, 2008 at 04:37:49PM +0200, Aurelien Jacobs wrote:
> > Michael Niedermayer wrote:
> > 
> > > On Sun, Aug 17, 2008 at 03:32:30PM +0200, Aurelien Jacobs wrote:
> > > > Peter Ross wrote:
> > > > 
> > > > > This patch flags SAMPLE_FMT_S24 as deprecated.
> > > > 

> bits_per_sample can NOT be used as SAMPLE_FMT_* bit count.
> It has a different and docuented purpose, it describes the coded bitstream
> and not the decoded samples, they match in bits only for lossless codecs.
> 
> example:
> the a demuxer sets bits_per_sample to 4 and passes the data to a ADPCM
> decoder which has SAMPLE_FMT_S16 output with 13 significant bits the
> last 3 being always 0

Thanks for taking the time to explain this. Revised patch within.

The proposed field make sense only for SAMPLE_FMT_S32. I've kept the language
generic, as it will have future utility when FFmpeg can manipulate 12/16-bit
luma planes.

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bits_per_sample_fmt.diff
Type: text/x-diff
Size: 560 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080819/78a09d1e/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080819/78a09d1e/attachment.pgp>



More information about the ffmpeg-devel mailing list