[FFmpeg-devel] [PATCH] split mdec.c from mpeg12.c

[Michael Niedermayer]

On Tue, Aug 19, 2008 at 11:49:55AM +0200, Diego Biurrun wrote:
> On Tue, Aug 19, 2008 at 03:32:32AM +0200, Michael Niedermayer wrote:
> > On Tue, Aug 19, 2008 at 03:22:28AM +0200, Diego Biurrun wrote:
> > > On Tue, Aug 19, 2008 at 02:20:56AM +0200, Diego Biurrun wrote:
> > > > Here is a little refactoring patch that moves mdec.c to a proper
> > > > separate file that can be conditionally compiled instead of #including
> > > > it from mpeg12.c.
> > > > 
> > > > --- libavcodec/mpeg12.c	(revision 14829)
> > > > +++ libavcodec/mpeg12.c	(working copy)
> > > > @@ -152,7 +151,7 @@
> > > >  
> > > > -static void init_vlcs(void)
> > > > +void ff_init_vlcs(void)
> > > 
> > > Should this function be marked av_cold (in a separate patch)?
> > 
> > yes
> 
> Done.
> 
> > > > @@ -620,7 +619,7 @@
> > > >  
> > > > -static inline int decode_dc(GetBitContext *gb, int component)
> > > > +inline int ff_decode_dc(GetBitContext *gb, int component)
> > > 
> > > I am being told that non-static inline functions can be problematic.
> > > There are two possible solutions:
> > > 
> > > - Move the function to a header file,
> > 
> > yes, but note this could end up rather messy and if it requires
> > 100 things to be made global then i would prefer to keep
> > #including mdec.c
> 
> See attached patch, it is rather simple.  If you prefer I could split
> out the rename upon commit.

ok, (and i dont mind it being not split)


> 
> > > - remove the inline keyword.
> > > 
> > > Aurelien did the latter when splitting off wmv2.c from msmpeg4.c.
> > 
> > Was this benchmarked?
> 
> Yes, this was discussed with you back then.  I ran some benchmarks,
> as did Aurelien:
> 
> http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2007-November/037852.html
> http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2007-November/037881.html

ok, i remember now :)

sleep deprication seems to have a negative effect on my memory.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080819/8a5ae2e8/attachment.pgp>