[FFmpeg-devel] Help commiting ok-ed parts of soc students

Ramiro Polla ramiro.polla
Tue Aug 19 19:21:43 CEST 2008


On Tue, Aug 19, 2008 at 2:07 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Tue, Aug 19, 2008 at 01:20:26PM -0300, Ramiro Polla wrote:
>> Hi Michael,
>>
>> Michael Niedermayer wrote:
>> > If someone could help commit ok -ed hunks of patches from SOC students that
>> > would be appreciated.
>>
>> Could you please not omit any part of the patch in your incremental
>> reviews? It makes applying them easier, since then we just have to go
>> through the review and check that the diff for the OKed - or + hunks are
>> the same. If a hunk is [...]'d it's harder to know what happened or
>> what's in the middle.
>
> sorry, ive noticed the same problem when i commited the ok-ed parts from a
> past patch by zhentan. (though your explanation is somewhat unclear)

My explanations usually are unclear =)

(Sometimes they don't even make sense to me a few hours later)




More information about the ffmpeg-devel mailing list