[FFmpeg-devel] [PATCH] Fix some typos in avfilter.h
Sun Aug 24 04:21:50 CEST 2008
Michael Niedermayer wrote:
> On Sun, Aug 24, 2008 at 02:56:42AM +0200, Michael Niedermayer wrote:
>> On Sat, Aug 23, 2008 at 11:23:45PM +0200, Stefano Sabatini wrote:
>>> Hi, as in subject.
>>> I'm not sure for the second hunk.
>> So why do you include it?
>> patches arent being submitted as a test for them being correct,
>> patches are submitted after the author is sure they are correct.
This is not always the case. Sometimes patches are submitted as "I am
proposing this change for consideration - what do people think about
it?". In fact, it could be argued that *all* patches are submitted under
that category, to one degree or another; certainly any "I will apply
this in N days if no one objects" patches would seem to fit it.
> btw in case anyone wonders
> from the 3 hunks
> the first fixes a missing char typo and likely correct
> the second is unneeded
> and the third is outright wrong and could lead serious confusion
> (thats all IMHO of course)
Agreed on all three points. There is a bad grammar issue in the third
hunk (beginning a sentence with "And" is almost never a good idea), but
the patch as it stands doesn't even try to change that.
Warning: Simply because I argue an issue does not mean I agree with any
side of it.
Secrecy is the beginning of tyranny.
More information about the ffmpeg-devel