[FFmpeg-devel] PATCH: fix broken WMA decoding
Sun Aug 24 10:30:03 CEST 2008
2008/8/24 Robert Swain <robert.swain at gmail.com>:
> 2008/8/24 Michael Niedermayer <michaelni at gmx.at>:
>> On Sat, Aug 23, 2008 at 04:34:44PM +0100, Robert Swain wrote:
>>> 2008/8/23 Jindrich Makovicka <makovick at gmail.com>:
>>> > revision 14758 (global sine window tables) broke WMA decoding. The
>>> > problem is that the tables are in opposite order (128...2048) than
>>> > wma.c expects. The solution is to either reverse the table order in
>>> > mdct.c or flip the index in wma.c (attached).
>>> Ah, indeed. Apologies. I prefer the patch you attached to reversing
>>> the table order and it looks OK to me. Michael?
> Actually, I'm not certain using "s->nb_block_sizes - i - 1" as the
> index will guarantee the correct index. I think rather
> "s->frame_len_bits - i - 7" would.
I'll have some conviction and apply this instead.
More information about the ffmpeg-devel