[FFmpeg-devel] [PATCH] Fix crash in libx264 when rc_eq is not set

Reimar Döffinger Reimar.Doeffinger
Tue Aug 26 21:40:43 CEST 2008


On Tue, Aug 26, 2008 at 08:08:09PM +0200, Stefano Sabatini wrote:
> I'm also for keeping that feature.
> 
> Ideally libx264 should be able to set its default value if libavcodec
> leaves it to NULL, but this would break (at least) old libx264
> versions.
> 
> So I propose again my first patch, which I attach.

Going by the previous discussions the right solution is
> if (avctx->rc_eq)
>     x4->params.rc.psz_rc_eq = avctx->rc_eq;

if you want to keep the functionality.




More information about the ffmpeg-devel mailing list