[FFmpeg-devel] Realmedia patch

[Ronald S. Bultje]

Hi Luca,

On Thu, Aug 28, 2008 at 11:56 AM, Luca Abeni <lucabe72 at email.it> wrote:
> Ronald S. Bultje wrote:
> [...]
>> Index: ffmpeg-svn/libavformat/rtsp.c
>> ===================================================================
>> --- ffmpeg-svn.orig/libavformat/rtsp.c        2008-08-27 19:03:58.000000000 -0400
>> +++ ffmpeg-svn/libavformat/rtsp.c     2008-08-28 09:06:31.000000000 -0400
>> @@ -42,6 +42,12 @@
>>      RTSP_STATE_PAUSED,
>>  };
>>
>> +enum RTSPServerType {
>> +    RTSP_SERVER_RTP = 0, /*< Standard-compliant RTP-server */
>
> It's still not clear why "= 0". If this assignment is not needed, I'd say to
> remove it. After this, I think the patch is ok. If it works and if noone
> complains in 2 or 3 days, commit it (in three different steps).

Oh, oops, sorry, forgot about that comment. So I always initialize my
enums to zero, not sure if it's needed. I can remove if preferred,
esp. since the default in the for() loop is now _RTP, not 0.

Thanks,
Ronald