[FFmpeg-devel] Realmedia patch

[Michael Niedermayer]

On Sat, Aug 30, 2008 at 10:39:55AM -0400, Ronald S. Bultje wrote:
> Hi Michael,
> 
> On Thu, Aug 21, 2008 at 12:05 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Mon, Aug 18, 2008 at 10:21:35AM -0400, Ronald S. Bultje wrote:
> >> @@ -1263,24 +1403,25 @@
> >>
> >>      av_log(s, AV_LOG_DEBUG, "hello state=%d\n", rt->state);
> >>
> >> +    if (!(rt->real_stream && rt->no_streams_chosen_yet)) {
> >> +        if (rt->state == RTSP_STATE_PAUSED) {
> >> -    if (rt->state == RTSP_STATE_PAUSED) {
> >> +            snprintf(cmd, sizeof(cmd),
> >> +                     "PLAY %s RTSP/1.0\r\n",
> >> +                     s->filename);
> >> -        snprintf(cmd, sizeof(cmd),
> >> -                 "PLAY %s RTSP/1.0\r\n",
> >> -                 s->filename);
> >> +        } else {
> >> -    } else {
> >
> > cosmetics ...
> 
> To best address the cosmetics, I'd like to apply a small cosmetics
> patch to rtsp_pause() and rtsp_play(), see attached. Is that OK? With
> attached, I can simply add an if(){ ... } around the relevant part,
> but the "else" maks that difficult in the current version. My patch
> removes the "else" case, which isn't needed since if() returns.

Id leave the {}
besides this iam fine with it but iam not rtsp maintainer ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I count him braver who overcomes his desires than him who conquers his
enemies for the hardest victory is over self. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080830/93a6eec9/attachment.pgp>