[FFmpeg-devel] [PATCH] Make a clear distinction between an unsupported codec and an unknown one

[Peter Ross]

On Sun, Aug 31, 2008 at 12:53:34PM +0200, Michael Niedermayer wrote:
> On Sun, Aug 31, 2008 at 06:56:48AM +0200, Vitor Sessak wrote:
> > See $subj. I got pretty confused by "Stream #0.1: Audio: 0x0000, 5512 Hz, 
> > mono, s16" meaning that a codec is known, but unsupported...
> >
> > -Vitor
> 
> > Index: libavcodec/utils.c
> > ===================================================================
> > --- libavcodec/utils.c	(revision 15050)
> > +++ libavcodec/utils.c	(working copy)
> > @@ -1091,8 +1091,12 @@
> >                       (enc->codec_tag >> 16) & 0xff,
> >                       (enc->codec_tag >> 24) & 0xff,
> >                        enc->codec_tag);
> > +        } else if (enc->codec_id) {
> > +            snprintf(buf1, sizeof(buf1), "unsuported (id 0x%04x)", enc->codec_id);
> > +        } else if (enc->codec_tag) {
> > +            snprintf(buf1, sizeof(buf1), "unknown (0x%04x)", enc->codec_tag);
> >          } else {
> > -            snprintf(buf1, sizeof(buf1), "0x%04x", enc->codec_tag);
> > +            snprintf(buf1, sizeof(buf1), "unknown");
> >          }
> 
> I think this is inconsistant now
> Before it just printed the tag now it prints the tag when its
> printable, if not and codec_id is not 0 the id and if not and
> id is 0 and the tag is not 0 the tag and ...
> Printing the ID in addition to the tag and "NONE" instead of
> 0x0000 or so seems more consistent to me

An enhancement to the unsupported case would be to actually print
the name of the codec. e.g. i am always forgetting which 0x16X
twocc refers to wmav3.

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080831/6fd4bc08/attachment.pgp>