[FFmpeg-devel] [PATCH] add tag/comment support to the raw flac demuxer

Jason Garrett-Glaser darkshikari
Fri Dec 5 06:52:23 CET 2008

On Thu, Dec 4, 2008 at 9:13 PM, Baptiste Coudurier
<baptiste.coudurier at gmail.com> wrote:
> Jason Garrett-Glaser wrote:
>> On Thu, Dec 4, 2008 at 11:06 AM, Baptiste Coudurier
>> <baptiste.coudurier at gmail.com> wrote:
>>> Hi,
>>> Michael Niedermayer wrote:
>>>> On Mon, Dec 01, 2008 at 02:18:02PM -0800, Jim Radford wrote:
>>>>> This patch adds support for parsing vorbis comments in plain flac
>>>>> streams.  Only metadata packets are parsed leaving the frame data to
>>>>> be parsed in raw 1024 byte chunks like before.
>>>> this wont work with flac in any container short of raw flac.
>>>> Thus IMO this is unacceptable
>>> It's not like flac would be put in another container
>> FLAC is used in MKV all the time for HDDVD/Blu-ray rips' raw audio
>> (people recompress from DTS-HD/similar)...
> "raw audio" ? FLAC is not raw.
> HDRIPs' around use AC3 and are forced to keep original bluray's track.

Sure, crappy Scene rips use AC3, but not everyone downloads crappy Scene rips.

I have seen rips with FLAC audio, recompressed from DTS-HD or LPCM.  Examples:

Sigur R?s Heima 2007 1080i MPEG2 DTS5.1 FLAC2.0-Xorp
Underworld Evolution BDrip 1080p MPEG2 FLAC 5.1 MKV
House Of Flying Daggers BDrip 1080p MPEG2 FLAC 5.1 MKV

Dark Shikari

More information about the ffmpeg-devel mailing list