[FFmpeg-devel] [PATCH] add tag/comment support to the raw flac demuxer

Baptiste Coudurier baptiste.coudurier
Fri Dec 5 07:44:08 CET 2008

Jason Garrett-Glaser wrote:
> On Thu, Dec 4, 2008 at 10:21 PM, Baptiste Coudurier
> <baptiste.coudurier at gmail.com> wrote:
>> Jason Garrett-Glaser wrote:
>>> On Thu, Dec 4, 2008 at 9:13 PM, Baptiste Coudurier
>>> <baptiste.coudurier at gmail.com> wrote:
>>>> Jason Garrett-Glaser wrote:
>>>>> On Thu, Dec 4, 2008 at 11:06 AM, Baptiste Coudurier
>>>>> <baptiste.coudurier at gmail.com> wrote:
>>>>>> Hi,
>>>>>> Michael Niedermayer wrote:
>>>>>>> On Mon, Dec 01, 2008 at 02:18:02PM -0800, Jim Radford wrote:
>>>>>>>> This patch adds support for parsing vorbis comments in plain flac
>>>>>>>> streams.  Only metadata packets are parsed leaving the frame data to
>>>>>>>> be parsed in raw 1024 byte chunks like before.
>>>>>>> this wont work with flac in any container short of raw flac.
>>>>>>> Thus IMO this is unacceptable
>>>>>> It's not like flac would be put in another container
>>>>> FLAC is used in MKV all the time for HDDVD/Blu-ray rips' raw audio
>>>>> (people recompress from DTS-HD/similar)...
>>>> "raw audio" ? FLAC is not raw.
>>>> HDRIPs' around use AC3 and are forced to keep original bluray's track.
>>> Sure, crappy Scene rips use AC3, but not everyone downloads crappy Scene rips.
>>> I have seen rips with FLAC audio, recompressed from DTS-HD or LPCM.  Examples:
>>> Blood.Diamond.2006.BluRay.1080p.x264.DTS.FLAC.5.1-Crow
>>> Memories.1995.Blu-ray.1080p.AC3.FLAC.x264-sJR
>>> Sigur R?s Heima 2007 1080i MPEG2 DTS5.1 FLAC2.0-Xorp
>>> Underworld Evolution BDrip 1080p MPEG2 FLAC 5.1 MKV
>>> House Of Flying Daggers BDrip 1080p MPEG2 FLAC 5.1 MKV
>> -Crow ? -sJR ? -Xorp ? And you call what crappy scene rips ? LOL
> Anyways, I seriously hope you're not arguing in favor of throwing away
> support for *files which exist in the wild* just because you don't
> like them and you're too lazy to fix the code to work correctly.

Of course not, Im actually arguing in favor of supporting flac metadata 
at demuxer level for now like stated. My point was also that in case 
flac was used in another container, metadata would be in the up level 
(in this case mkv).

> I mean, if ffmpeg can support game formats that nobody actually uses,
> we can definitely support formats that people *do* use, and do it
> correctly.

Definitely, this has always been FFmpeg goal, and also to support as 
many files as it is possible to, even broken ones, if hacks and 
workaround are reasonable.

Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org

More information about the ffmpeg-devel mailing list