[FFmpeg-devel] [PATCH] Issue 636 : ALAC encoding sometimes fails

[Michael Niedermayer]

On Fri, Dec 05, 2008 at 10:09:16AM +0530, Jai Menon wrote:
> Hi,
> 
> Attached patch fixes issue 636 and a few other fringe cases where the
> alac encoder produces
> lossy output. I'm behind a NAT and svn doesn't work, so could someone
> please apply. Thanks.
> 
> Regards,
> 
> Jai

> Index: libavcodec/alacenc.c
> ===================================================================
> --- libavcodec/alacenc.c	(revision 15797)
> +++ libavcodec/alacenc.c	(working copy)
> @@ -253,7 +253,8 @@
>  
>              sum >>= lpc.lpc_quant;
>              sum += samples[0];
> -            residual[i] = samples[lpc.lpc_order+1] - sum;
> +            residual[i] = (samples[lpc.lpc_order+1] - sum) << (32 - s->write_sample_size) >>
> +                          (32 - s->write_sample_size);
>              res_val = residual[i];

you are missing a int32_t cast in there, without it this wont work on
systems where int is not exactly 32bit

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081205/93db7c9e/attachment.pgp>