[FFmpeg-devel] [PATCH] high precision mp3 decoding needs CONFIG_AUDIO_NONSHORT which is never set

[Benoit Fouet]

Hi,

On 12/09/2008 12:42 AM, Diego Biurrun wrote:
> On Mon, Dec 08, 2008 at 12:29:16PM +0100, Benoit Fouet wrote:
>   
>> On 12/08/2008 12:10 PM, Diego Biurrun wrote:
>>     
>>> On Mon, Dec 08, 2008 at 10:00:57AM +0100, Benoit Fouet wrote:
>>>   
>>>       
>>>> On 12/07/2008 03:25 PM, Michael Niedermayer wrote:
>>>>     
>>>>         
>>>>> On Sun, Dec 07, 2008 at 02:51:57PM +0100, Mathieu Velten wrote:
>>>>>   
>>>>>           
>>>>>> patch attached
>>>>>>         
>>>>>>             
>>>>> looks ok
>>>>>       
>>>>>           
>>>> reg tests fail here with this patch:
>>>>         
>>> Do they also fail if you make the change in both mpegaudiodec.c and
>>> mpegaudio.h?
>>>       
>> yes, they also fail
>>     
>
> This does not look right.  Why are the libavformat regression tests
> failing due to a change in libavcodec?  And especially a change to
> preprocessor conditions that are not normally fulfilled?
>
>   

they are not fulfilled at the moment.
#ifdef CONFIG_AUDIO_NONSHORT is an #if 0, no ?

Ben