[FFmpeg-devel] [PATCH] ALSA for libavdevice

Diego Biurrun diego
Tue Dec 9 20:01:30 CET 2008


On Tue, Dec 09, 2008 at 07:17:07PM +0100, Nicolas George wrote:
> 
> The attached patch is the ALSA code from Luca Abeni (Roundup issue 247),
> updated for the current code base and somewhat reworked. It works on my
> system.
> 
> --- a/libavdevice/Makefile
> +++ b/libavdevice/Makefile
> @@ -20,6 +20,9 @@ OBJS-$(CONFIG_X11_GRAB_DEVICE_DEMUXER)   += x11grab.o
>  # external libraries
>  OBJS-$(CONFIG_LIBDC1394_DEMUXER)         += libdc1394.o
>  
> +OBJS-$(CONFIG_ALSA_DEMUXER)              += alsa-audio-common.o alsa-audio-dec.o
> +OBJS-$(CONFIG_ALSA_MUXER)                += alsa-audio-common.o alsa-audio-enc.o
> +
>  OBJS-$(CONFIG_AUDIO_BEOS_DEMUXER)        += beosaudio.o
>  OBJS-$(CONFIG_AUDIO_BEOS_MUXER)          += beosaudio.o

Why do you add it at this weird point in the Makefile?

> --- /dev/null
> +++ b/libavdevice/alsa-audio.h
> @@ -0,0 +1,53 @@
> +
> +#ifndef ALSA_AUDIO_H
> +#define ALSA_AUDIO_H

missing multiple inclusion guard prefix

Diego




More information about the ffmpeg-devel mailing list