[FFmpeg-devel] [PATCH] ACDV (JPEG) codec

Diego Biurrun diego
Wed Dec 10 09:01:08 CET 2008


On Tue, Dec 09, 2008 at 11:51:04PM -0800, Mike Melanson wrote:
> Diego Biurrun wrote:
> > On Tue, Dec 09, 2008 at 09:26:21PM -0800, Mike Melanson wrote:
> >> One-line patch to riff.c to support ACDV codec which is actually just  
> >> full JPEG files stored in individual AVI frames.
> > 
> > Why send a patch for this triviality?  Just commit...
> 
> A few reasons:
> 
> 1) I'm never quite sure what counts as triviality.
> 
> 2) For all I know, I could have messed up the order in riff.c without 
> recognizing it.
> 
> 3) This gives you a chance to jump on me about forgetting to document 
> something (although I checked around and it doesn't look like we 
> document FourCCs that map to known codecs, though perhaps we should).
> 
> 4) I commit so rarely that I'm biding my time to remember how it works. :)

I'll rephrase my words then: Looks OK, commit.

Diego




More information about the ffmpeg-devel mailing list