[FFmpeg-devel] _t POSIX namespace issues

Ronald S. Bultje rsbultje
Thu Dec 11 17:54:00 CET 2008


Hi,

On Thu, Dec 11, 2008 at 11:49 AM, Reimar D?ffinger
<Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> On Thu, Dec 11, 2008 at 04:29:48PM +0100, Luca Abeni wrote:
>> Diego Biurrun wrote:
>> > libavformat/rtp.h:} rtp_payload_data_t;
>>
>> I personally do not like this kind of typedefs; is it ok if I change
>> all the instances of "rtp_payload_data_t" to "struct rtp_payload_data"?
>
> Since I won't touch that code anyway it does not matter, but I do not
> like the extra "struct" when it is used in "thousands" of places,
> because then it often becomes annoying clutter and is bad for
> readability (obviously, that is a personal opinion).
> For gxf.c it was only three places so I removed the typedef, too.

I don't quite understand, what is the disadvantage of the typedef? I
find the struct prefix highly annoying.

Ronald




More information about the ffmpeg-devel mailing list