[FFmpeg-devel] _t POSIX namespace issues

[Luca Abeni]

Hi Ronald,

Ronald S. Bultje wrote:
[...]
>>> I personally do not like this kind of typedefs; is it ok if I change
>>> all the instances of "rtp_payload_data_t" to "struct rtp_payload_data"?
>> Since I won't touch that code anyway it does not matter, but I do not
>> like the extra "struct" when it is used in "thousands" of places,
>> because then it often becomes annoying clutter and is bad for
>> readability (obviously, that is a personal opinion).
>> For gxf.c it was only three places so I removed the typedef, too.
> 
> I don't quite understand, what is the disadvantage of the typedef? I
> find the struct prefix highly annoying.

No real disadvantage; as I said, I think it is just a matter of personal 
opinions... I like the "struct" keyword reminding me that something is a 
structure, but I have no serious reason for this... So, if people like 
the typedef I'll not remove it. I'll just remove the final "_t" 
(probably during the weekend, when I'll finally have some spare time).



				Luca


> 
> Ronald
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel