[FFmpeg-devel] [RFC] allow overriding of $nm

[Reimar Döffinger]

On Sat, Dec 13, 2008 at 03:07:34PM +0000, M?ns Rullg?rd wrote:
> Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> writes:
> > On Sat, Dec 13, 2008 at 03:31:44PM +0100, Diego Biurrun wrote:
> >> On Sat, Dec 13, 2008 at 03:24:22PM +0100, Reimar D?ffinger wrote:
> >> > On Sat, Dec 13, 2008 at 02:14:14PM +0000, M?ns Rullg?rd wrote:
> >> > > Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> writes:
> >> > > > --- configure	(revision 16087)
> >> > > > +++ configure	(working copy)
> >> > > > @@ -129,6 +129,7 @@
> >> > > >    echo "  --extra-version=STRING   version string suffix []"
> >> > > > +  echo "  --nm=NM                  use nm tool [$nm]"
> >> > > 
> >> > > $nm will not be set here.
> >> > 
> >> > That's what I expected, but I just copy-and-paste from the --cc
> >> > description.
> >> > Anyway, here is the updated version.
> >> 
> >> Apply with the suggested change:
> >> 
> >> > --- configure	(revision 16089)
> >> > +++ configure	(working copy)
> >> > @@ -120,6 +120,7 @@
> >> >    echo "  --target-os=OS           compiler targets OS [$target_os]"
> >> >    echo "  --target-exec=CMD        command to run executables on target"
> >> >    echo "  --target-path=DIR        path to view of build directory on target"
> >> > +  echo "  --nm=NM                  use nm tool"
> >> >    echo "  --cc=CC                  use C compiler CC [$cc]"
> >> 
> >> [nm]
> >
> > Problem is, that is not true when cross-compiling (with cross-compile
> > prefix). I'd say no comment is better than a wrong one? Also the issue
> > should be fixed in some way that is consistent with --cc anyway...
> 
> I prefer none over wrong.  The others should be fixed separately.

I applied it as it was, it's trivial to change once we decided how to
fix things.