[FFmpeg-devel] [PATCH] define _BSD_SOURCE for bktr.c
Sat Dec 13 21:54:29 CET 2008
On Sat, Dec 13, 2008 at 02:26:57PM +0100, Reimar D?ffinger wrote:
> On Sat, Dec 13, 2008 at 01:07:15PM +0100, Reimar D?ffinger wrote:
> > > patch-tests_regression_sh: half-merged, half mysterious
> > I just realized I made a bad assumption there, the sed expression
> > probably is wrong...
> > Which of course also means all this not a good solution, since we have
> > two different md5 binaries with no way to distinguish them except that
> > hopefully one is in the path and the other in /sbin, which is a bad
> > way...
> > I'll check if sed 's#.*= ##' is the right one (too many of the
> > regression tests fail, which is why I missed it originally).
> Oh silly me, it actually works right in the regression tests, I forgot
> to add -r when trying it on the command-line, so that part is okay.
> The LD_LIBRARY_PATH is just to allow make test without installing first,
> but it's not portable (e.g. won't work on Windows).
and did I submit this to you guys? no. why? because it's not
for upstream inclusion. so why bother saying it's not portable
it's like complaining that OpenBSD doesn't follow standards, then when
it does (_BSD_SOURCE vs POSIX), you complain that it's stupid.
I dropped maintainership of ffmpeg because of all this needless
bashing. I hope you don't get an onslaught of idiots trying to
make ffmpeg work on OpenBSD ...
jakemsr at sdf.lonestar.org
SDF Public Access UNIX System - http://sdf.lonestar.org
More information about the ffmpeg-devel