[FFmpeg-devel] [PATCH 0/2] Fix strict aliasing violations in AAC and AC3 parsers

Michael Niedermayer michaelni
Sun Dec 14 23:15:36 CET 2008

On Sun, Dec 14, 2008 at 08:53:16PM +0000, Mans Rullgard wrote:
> The AAC and AC3 parsers both violate strict aliasing rules when using
> a uint64_t variable as buffer for the bitstream reader.  Although I am
> not entirely certain of the strict validity of these patches, they are
> sufficient to make gcc do the right thing, and they can't make things
> any worse.
> Please comment.

ive no objections to these patches, though personally id rather add
-fno-strict-aliasing to the flags of these 2 files ...
not because of these 2, but because more than half of the code in ffmpeg
violates the aliasing rules and would we replace all that by unions
readability would suffer very significantly.


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081214/5b0cd7ac/attachment.pgp>

More information about the ffmpeg-devel mailing list