[FFmpeg-devel] [PATCH] oops I broke rdt.c

[Michael Niedermayer]

On Tue, Dec 16, 2008 at 09:00:34AM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> $subj says it all, my recent commit to remove usage of RMContext in
> rdt (r16110) broke RDT reading, not sure how that could happen but
> it's probably poor testing (i.e. testing with streams that don't
> actually use that function) and focussing my testing more on plain RM
> files (that patch is part of the set of patches to implement RMStream
> etc.) and forgetting to do thorough testing on RDT streams.
[...]
> Index: ffmpeg-svn/libavformat/rdt.c
> ===================================================================
> --- ffmpeg-svn.orig/libavformat/rdt.c	2008-12-16 08:53:46.000000000 -0500
> +++ ffmpeg-svn/libavformat/rdt.c	2008-12-16 08:53:56.000000000 -0500
> @@ -314,6 +314,7 @@
>                                                  NULL, NULL, NULL, NULL);
>          }
>      } else {
> +        rdt->audio_pkt_cnt[st->id] =
>          ff_rm_retrieve_cache (rdt->rmctx, rdt->rmctx->pb, st, pkt);
>          if (rdt->audio_pkt_cnt[st->id] == 0 &&
>              st->codec->codec_id == CODEC_ID_AAC)

i see code like
 st->id = get_be16(pb);
in rmdec.c
thus this looks suspect, given that the array is not that large

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081216/43a6a97f/attachment.pgp>