[FFmpeg-devel] [PATCH]Silence icc warnings

[Carl Eugen Hoyos]

Michael Niedermayer <michaelni <at> gmx.at> writes:

[...]

> > Index: libavutil/common.h
> > ===================================================================
> > --- libavutil/common.h	(revision 16246)
> > +++ libavutil/common.h	(working copy)
> > @@ -76,7 +76,7 @@
> >  #endif
> >  
> >  #ifndef av_cold
> > -#if AV_GCC_VERSION_AT_LEAST(4,3)
> > +#if !defined(__ICC) && AV_GCC_VERSION_AT_LEAST(4,3)
> 
> these things should be 
> AV_GCC_VERSION_AT_LEAST() || AV_ICC_VERSION_AT_LEAST()

No, that would not work because icc sets __GCC__ (and additionally, it sets it
differently depending on /usr/bin/gcc on the system it gets installed).
For all three cases, currently, all known icc versions fail: I tested the newest
one (and older ones).

May I apply the patch?

Carl Eugen