[FFmpeg-devel] [PATCH] graph2dot tool

Diego Biurrun diego
Sat Dec 27 12:59:08 CET 2008


On Sat, Dec 27, 2008 at 12:19:10PM +0100, Stefano Sabatini wrote:
> On date Saturday 2008-12-27 11:11:38 +0100, Diego Biurrun encoded:
> > On Sat, Dec 27, 2008 at 12:39:27AM +0100, Stefano Sabatini wrote:
> > > 
> > > [...]
> > > 
> > > I should have been fixed all the C99 mixed declaration around, and
> > > done some simplification.
> > > 
> > > I also implemented a getopt() based CLI parsing mechanism, extended
> > > the interface and fixed other random errors.
> > > 
> > > typedef struct Line {
> > >     char data[256];
> > >     struct Line *next;
> > > } Line;
> > 
> > Capitalized names are ugly and you might as well get rid of the typedef..
> 
> I followed the libav* convenction (which I like) of using
> CapitalizedNames for typedeffed structs, but if you prefer I can simply
> use struct line in the code.

There exist mixed opinions on the subject, but I generally prefer
avoiding typedefs.

Diego




More information about the ffmpeg-devel mailing list