[FFmpeg-devel] rmdec.c: double free

[Michael Niedermayer]

On Sun, Dec 28, 2008 at 03:44:17PM +0100, Reimar D?ffinger wrote:
> On Sun, Dec 28, 2008 at 03:21:49PM +0100, Michael Niedermayer wrote:
> > On Sun, Dec 28, 2008 at 09:08:45AM -0500, Ronald S. Bultje wrote:
> > > Hi,
> > > 
> > > my previous commit induces a double free in priv_data. Attached patch
> > > fixes this.
> > 
> > the bug is a double free, the fix has to involve removing a av_free()
> > 
> > also if ff_rm_free_rmstream() frees priv_data (and that looks invalid already)
> > then priv_data has to be NULL after ff_rm_free_rmstream()
> 
> I'd suspect this would be a proper solution, though it may be disputable
> if it should be done in two steps (the av_free -> av_freep should not be
> necessary (I did not test) but IMO is preferable):

patch ok


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081228/674bedc8/attachment.pgp>